Revert "detach-netns: simplify unshare helper"#500
Merged
AkihiroSuda merged 3 commits intorootless-containers:masterfrom Mar 10, 2025
Merged
Revert "detach-netns: simplify unshare helper"#500AkihiroSuda merged 3 commits intorootless-containers:masterfrom
AkihiroSuda merged 3 commits intorootless-containers:masterfrom
Conversation
This reverts commit 0dfe464. Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
Signed-off-by: Akihiro Suda <akihiro.suda.cz@hco.ntt.co.jp>
fahedouch
reviewed
Mar 10, 2025
| return err | ||
| } | ||
| defer tempNS.Close() | ||
| tempNSPath := tempNS.Path() |
Contributor
There was a problem hiding this comment.
@AkihiroSuda, I don't understand why ns.WithNetNSPath cannot detect the AppArmor profile configuration.
Member
Author
There was a problem hiding this comment.
Probably a race condition?
nerdctl CI was green without reverting this commit, but BuildKit CI was failing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This reverts commit 0dfe464.
Revert:
Due to a regression moby/buildkit#5825 (comment)
Originally posted by @AkihiroSuda in moby/buildkit#5825 (comment)